Fix #986 do not include xmlns namespace from WSDL #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathansamson
force-pushed
the
fix-xmlns
branch
from
4414491 to
b27d7b5
Compare
|
Checked this on server that was giving me issues before and I can confirm this fixes my issue |
|
Need to investigate why the tests are now failing |
|
ok it appears to be failing on master too, I confirmed this was due to a recent release of mail 2.8.0 which broke a test, this is now fixed. This can merge once everything is confirmed green with that fix Edit: This worked locally with the patch from main applied. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change is this?
Bugfix for #986
Did you add tests for your changes?
Changed test
Summary of changes
Exclude xmlns coming from WSDL as this causes issues for some servers, and is genreally not needed
Other information
Not yet checked with my server implementation but intend to do so soon