Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRIB-276: converts UserAPI test back to an integration test #283

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

mrsbluerose
Copy link
Collaborator

Pull request #257 for issue #253 converted UserAPITEST to a unit test. This ticket specifically undoes the commit 23fdb64. It keeps other changes, which included using the UserTestConstants.

Testing:

  • all tests run as expected
  • MVN verify runs the UserAPIIT test

- This reverts commit 23fdb64
- TRIB-253 converted this UserAPI test from an integration test to a unit test. This commit is undoing that specific change.
- removes userRole set from createUserWhenErrorThrown
@mrsbluerose mrsbluerose linked an issue Sep 4, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.55%. Comparing base (0faee8e) to head (30ba5f2).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #283   +/-   ##
==========================================
  Coverage      82.55%   82.55%           
  Complexity       556      556           
==========================================
  Files             79       79           
  Lines           1685     1685           
  Branches         275      275           
==========================================
  Hits            1391     1391           
  Misses           254      254           
  Partials          40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haxwell haxwell merged commit 09d2630 into savvato-software:develop Sep 5, 2024
4 checks passed
@mrsbluerose mrsbluerose deleted the TRIB-276 branch September 5, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert the UserAPI unit test back to an integration test
2 participants