Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation: admin fields/fieldsets override #81

Closed
agfunder opened this issue Jun 28, 2017 · 1 comment
Closed

documentation: admin fields/fieldsets override #81

agfunder opened this issue Jun 28, 2017 · 1 comment

Comments

@agfunder
Copy link

If you use ConcurrentModelAdmin , and you manually set fieldsets or fields in admin, you must ensure the version field gets added to the admin. Otherwise concurrency checks will not be enforced.

This small detail took me almost 2 hours to discover. 1 line of documentation would protect future users from this.

Btw: thank you for a very cool library 👍

saxix added a commit that referenced this issue Jul 6, 2017
@saxix
Copy link
Owner

saxix commented Jul 7, 2017

a4e5460 adds a warning in documentation and a check for the System check framework (only enabled for django >= 1.11)

@saxix saxix closed this as completed Jul 7, 2017
saxix added a commit that referenced this issue Mar 28, 2019
* release/1.4: (24 commits)
  updates CHANGES
  fixes py3.4 tests
  enable ConcurrentModelAdmin.check only on django>=1.11
  closes issue #81
  removes some doctests
  minor tests cleanup
  fixes wrong import
  some code clean, removes old compatibility related code
  updates docs
  updates docs
  fixes docs pagination
  add test for issue #54 (just asa reference)
  updates CHANGES
  fixes issue #80
  Fix warnings on django 1.11 with Python 3.6 -Wall
  updates docs
  updates tests
  removes unused tests requirements
  removes double requirement in testing
  pep8 and minor updates
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants