Silently fail to 'enter' regular files #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duganchen
force-pushed
the
do_not_spam_can_not_enter_file
branch
from
32598f6
to
5626422
Compare
|
I think we can use focused_node's built-in is_dir and symlink.is_dir, without needing a system call. |
|
I changed it to use focused_node().is_dir() and tested it. With both regular files and directories, and with symlinks of regular files and directories. |
sayanarijit
requested changes
Jul 17, 2023
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silently fail to "Enter" regular files. Entering only makes sense for directories.
This fixes #653 (comment)
I don't know Rust at all, so I make no claims to the code quality. But I have tested this change and it does work.