[FIX] wrong warning message on GIF attachment + message ordering on winner detection #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acorpuz
approved these changes
May 21, 2022
|
@valeriobelcastro L'inversione dell'ordine dei messaggi ha un motivo particolare? |
OpenCode
requested changes
May 22, 2022
Volevo corregge la issue #32 solo che dopo aver committato ho pensato che non coprisse tutti i casi e l'ho riportato com'era. Nel caso che si era presentato l'altra volta con la vittoria di Biancalaura funzionava, però il controllo del messaggio più vecchio va fatto sul messaggio citato e non sulla GIF |
OpenCode
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to fix wrong warning error message when posting valid GIF as attachment instead of picking it from discord ones
fix #33