Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add neural networks and bug fixes #79

Merged
merged 42 commits into from
Mar 16, 2023
Merged

Add neural networks and bug fixes #79

merged 42 commits into from
Mar 16, 2023

Conversation

MikhailKuz
Copy link
Contributor

@MikhailKuz MikhailKuz commented Feb 22, 2023

Additions

Fixes

dev-rinchin

This comment was marked as outdated.

dev-rinchin
dev-rinchin previously approved these changes Mar 7, 2023
"id": "8a26dc61",
"metadata": {},
"source": [
"## 4. Available built-in models"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to place this section before section with TabularAutoML init

"outputs": [],
"source": [
"DATASET_DIR = '../data/'\n",
"DATASET_NAME = 'sampled_app_train.csv'\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove redundant variables DATASET_NAME and DATASET_DIR -- they are used just only once

"source": [
"### 0.1. Import libraries\n",
"\n",
"Here we will import the libraries we use in this kernel:\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant comments in lines 105-107

"id": "0ecdf10d",
"metadata": {},
"source": [
"### 4.1. MLP (`\"mlp\"`)\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, add links to description of NN architecture for every section below

"metadata": {},
"source": [
"- `bs` - batch_size\n",
"- `snap_params` - early stopping and checkpoint averaging params, swa\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add definition for "swa"

@dev-rinchin dev-rinchin self-requested a review March 14, 2023 08:26
"id": "bbf8a589",
"metadata": {},
"source": [
"#### 6.1.2 Define by yourself whole pipeline"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"#### 6.1.2 Define by yourself whole pipeline"
"#### 6.1.2 Define the pipeline by yourself"

try:
last_layer = list(
filter(
lambda x: isinstance(x, nn.Linear) or isinstance(x, nn.Sequential),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all lambda functions.

Check whether you can load automl with nn on disk and load it.

@DESimakov DESimakov merged commit f2ef45e into master Mar 16, 2023
@dev-rinchin dev-rinchin deleted the feature/nn branch August 28, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants