core: ustrtoull: convert zero length strings to 0 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strtoull sets errno to EINVAL for empty strings. This change mimics the behavior as it was before the ustrtoull refactoring in 6e4f913.
|
It can be, but....
Thanks ! |
|
Hello @sbabic,
May I then suggest to go to repository Settings and disable the "Pulls" menu? That will help reduce both contributors and maintainers work. |
|
Hi Gianpaolo,
On 04/09/2018 17:28, Gianpaolo Macario wrote:
Hello @sbabic <https://github.com/sbabic>,
github is not used for PR
May I then suggest to go to repository Settings and disable the "Pulls"
menu?
You can suggest but this is what I looked for a long time and I never
find a way to disable.
If I go in "Settings", I can disable "Issues" (already done).
But I cannot find anything to disable "Pull".
If you know how, please tell me...I am maybe blind, I cannot find it.
That will help reduce both contributors and maintainers work.
Best regards,
Stefano
…--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
|
|
Hi @sbabic, my apologies I wrote my previous reply on the phone, with the assumption that the setting was close to the one for the Issues. Sorry for the noise, and thanks again for your work with swupdate! |
This was referenced Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, parse_common_attributes() can not deal with an empty offset value.