Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

managing /gitlab-shell/hooks/update breaks editing via web interface #202

Closed
sammcj opened this issue Nov 24, 2014 · 0 comments · Fixed by #204
Closed

managing /gitlab-shell/hooks/update breaks editing via web interface #202

sammcj opened this issue Nov 24, 2014 · 0 comments · Fixed by #204

Comments

@sammcj
Copy link

sammcj commented Nov 24, 2014

Adding the below hooks/update file in to gitlab-shell breaks editing files via gitlab's web interface.

Removing the file / commenting out the block in install.pp fixes the issue and doesn't seem to break anything else?

install.pp:140

  file { "${git_home}/gitlab-shell/hooks/update":
    ensure  => present,
    content => template('gitlab/update.erb'),
    mode    => '0775',
    require => File["${git_home}/gitlab-shell/config.yml"],
  }

GitLab 7.3.2
GitLab Shell 2.0.1
GitLab API v3
Ruby 2.1.2p95
Rails 4.1.1
alexcern added a commit to cernops/puppet-gitlab that referenced this issue Jan 13, 2015
@alexcern
Add a parameter to disable rbenv configuration
989bce1 
This uses a different method to change shebang line in
gitlab-shell hooks and hence fixes sbadia#202.
alexcern added a commit to cernops/puppet-gitlab that referenced this issue Jan 13, 2015
@alexcern
Add a parameter to make rbenv configuration optional
64f0fce 
This incidently provides a workaround for sbadia#172.
This uses a different method to change ruby path in
gitlab-shell hooks when rbenv is used and hence
fixes sbadia#202 as well.
@alexcern alexcern mentioned this issue Jan 13, 2015
Merged
alexcern added a commit to cernops/puppet-gitlab that referenced this issue Jan 30, 2015
@alexcern
Add a parameter to make rbenv configuration optional
9c3a817 
This incidently provides a workaround for sbadia#172.
This uses a different method to change ruby path in
gitlab-shell hooks when rbenv is used and hence
fixes sbadia#202 as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a parameter to make rbenv configuration optional cernops/puppet-gitlab
1 participant
@sammcj