Use bundle check for gem install (closes: #93) #99
+5
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.git_setup_done was removed in profit to bundle check cmd (see log after) .gitlab_setup_done is keept in order to not re-run initial setup. git@gitlab:~/gitlab$ bundle check The Gemfile's dependencies are satisfied git@gitlab:~/gitlab$ echo $? 0 git@gitlab:/tmp/gitlabhq$ bundle check The following gems are missing ... git@gitlab:/tmp/gitlabhq$ echo $? 1
ghost
assigned 
|
Big 👍 |
Open
|
I didn't even realize bundle check was existed until @igalic presented it. This is obviously a better solution. I won't have a chance to run a test until either this afternoon or tomorrow, but the changes look good to me if they worked for you. |
|
Yep it's a better/cleaner solution, |
atomaka
added a commit
that referenced
this pull request
Dec 10, 2013
Use bundle check for gem install (closes: #93)
|
Looking good after a quick smoke test and rspec! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated and everything went good (initial/re-run), thanks @igalic for pointing this !
.git_setup_donewas removed in profit tobundle checkcmd (see log after).gitlab_setup_doneis keept in order to not re-run initial setup.(Travis and functional testing with vagrant was happy)