refactor: change react to a peer dependency

BREAKING CHANGE: react is now a peer dependency of our react package.
sbb-design-systems · Dec 11, 2024 · 1e806ed · 1e806ed
1 parent a59064e
commit 1e806ed
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/src/react-experimental/package.json b/src/react-experimental/package.json
@@ -12,11 +12,11 @@
   "peerDependencies": {
     "@sbb-esta/lyne-elements": "0.0.0-PLACEHOLDER",
     "@sbb-esta/lyne-elements-experimental": "0.0.0-PLACEHOLDER",
-    "@sbb-esta/lyne-react": "0.0.0-PLACEHOLDER"
+    "@sbb-esta/lyne-react": "0.0.0-PLACEHOLDER",
+    "react": "^18.2.0 || ^19.0.0"
   },
   "dependencies": {
     "@lit/react": "0.0.0-LITREACT",
-    "react": "0.0.0-REACT",
     "tslib": "0.0.0-TSLIB"
   },
   "publishConfig": {

diff --git a/src/react/package.json b/src/react/package.json
@@ -10,11 +10,11 @@
   ],
   "type": "module",
   "peerDependencies": {
-    "@sbb-esta/lyne-elements": "0.0.0-PLACEHOLDER"
+    "@sbb-esta/lyne-elements": "0.0.0-PLACEHOLDER",
+    "react": "^18.2.0 || ^19.0.0"
   },
   "dependencies": {
     "@lit/react": "0.0.0-LITREACT",
-    "react": "0.0.0-REACT",
     "tslib": "0.0.0-TSLIB"
   },
   "publishConfig": {

diff --git a/tools/vite/package-json-template.ts b/tools/vite/package-json-template.ts
@@ -29,7 +29,6 @@ export function packageJsonTemplate(
       const litVersion = rootPackageJson.dependencies.lit.match(/\d+\.\d+\.\d+/);
       const litObserversVersion =
         rootPackageJson.devDependencies['@lit-labs/observers'].match(/\d+\.\d+\.\d+/);
-      const reactMajorVersion = +rootPackageJson.devDependencies.react.match(/\d+/);
       const litReactVersion = rootPackageJson.devDependencies['@lit/react'].match(/\d+\.\d+\.\d+/);
       const tslibVersion = rootPackageJson.devDependencies.tslib.match(/\d+\.\d+\.\d+/);
       const packageJsonTemplate = readFileSync(
@@ -41,7 +40,6 @@ export function packageJsonTemplate(
         .replaceAll('0.0.0-LITOBSERVERS', `^${litObserversVersion}`)
         .replaceAll('0.0.0-LITREACT', `^${litReactVersion}`)
         .replaceAll('0.0.0-TSLIB', `^${tslibVersion}`)
-        .replaceAll('0.0.0-REACT', `^${reactMajorVersion}.0.0`)
         .replaceAll('0.0.0-LIT', `^${litVersion}`);
       const packageJson = JSON.parse(packageJsonContent);
       for (const key of ['author', 'license', 'repository', 'bugs']) {