Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Change request]: changes for sbb-train-wagon (type "closed", sleeping car/couchette) #2681

Closed
3 tasks done
Frenggi opened this issue May 23, 2024 · 0 comments · Fixed by #3199
Closed
3 tasks done

[Change request]: changes for sbb-train-wagon (type "closed", sleeping car/couchette) #2681

Frenggi opened this issue May 23, 2024 · 0 comments · Fixed by #3199
Assignees
@jeripeierSBB

Comments

@Frenggi
Copy link

Frenggi commented May 23, 2024 •
edited by mcilurzo
Loading

Preflight Checklist

Request type

Request for enhancement of a component

It affects the following packages

Components

Functionality

As discussed with SBB Mobile and sbb.ch we want to make a few slight changes on the display of the train formation.

  • for sleeping cars and couchettes, the attribute icon should be placed inside the wagon frame
  • the design of the closed wagon has to be changed: crossed-through frame

Link to design proposal file

https://www.figma.com/design/9r6xSfNmEfCFxl1yFYedrj/Lyne-Components?m=auto&node-id=43654-271442&t=LMy9FQ5CJzbAblb5-1
@jeripeierSBB jeripeierSBB moved this from Funnel to sbb.ch Priority in ESTA Web Lyne Design System May 23, 2024
@jeripeierSBB jeripeierSBB self-assigned this Oct 17, 2024
@jeripeierSBB jeripeierSBB moved this from Next to In progress in ESTA Web Lyne Design System Oct 28, 2024
@jeripeierSBB jeripeierSBB mentioned this issue Nov 6, 2024
Merged
jeripeierSBB added a commit that referenced this issue Nov 20, 2024
@jeripeierSBB
feat(sbb-train-formation): introduce new types and refactoring (#3199)
8eb7ae6 
Closes #2681

BREAKING CHANGE: The `hide-wagen-label` property of the
`sbb-train-formation` was removed. Now it automatically doesn't show the
label if no label is set on all the wagons.
The i18n `i18nClosedCompartmentLabel()` method doesn't take
`wagonNumber` as an argument anymore but is a constant now.
Additionally, there are some visual changes:
- `sbb-train-wagon`: The `ouccpancy` property doesn't default to `none`
anymore but to `null`. Please replace the currently undefined occupancy
property with the value `none`.
- `sbb-train-wagon`: Previously for the locomotive the label was not
displayed, but now it would, as soon as there is one provided
- `sbb-train-formation`: The inline padding (left / right) was removed
but can be set by CSS variable. See documentation.
@github-project-automation github-project-automation bot moved this from In progress to Done in ESTA Web Lyne Design System Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeripeierSBB jeripeierSBB

Labels
None yet
Projects
ESTA Web Lyne Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sbb-train-formation): introduce new types and refactoring sbb-design-systems/lyne-components
2 participants
@Frenggi @jeripeierSBB