feat(sbb-toggle): implement form association #3409
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomMenga
changed the title
github-actions
bot
added
pr: peer review required
TomMenga
changed the title
TomMenga
added
preview-available
pr: peer review required
TomMenga
commented
Feb 18, 2025
Comment on lines
-86
to
-94
| // Enforce disabled state from parent. | ||
| if (!this._toggle) { | ||
| // Ignore illegal state. Our expectation is that a sbb-toggle-option | ||
| // always has a parent sbb-toggle. | ||
| } else if (this._toggle.disabled && !this.disabled) { | ||
| this.disabled = true; | ||
| } else if (!this._toggle.disabled && this.disabled) { | ||
| this.disabled = false; | ||
| } |
There was a problem hiding this comment.
I removed this logic to simplify the dependency between the toggle and the toggle-option.
I decided to do it for two reasons:
1 - The sbb-toggle is also disabled when formDisabled. Which is a protected property that is not accessible from the toggle option.
2 - It was a protection against a misuse case (which we generally do not cover)
jeripeierSBB
requested changes
Feb 18, 2025
| @@ -97,8 +97,55 @@ class SbbToggleElement extends LitElement { | |||
| this.addEventListener?.('keydown', (e) => this._handleKeyDown(e)); | |||
| } | |||
|
|
|||
| /** @internal */ | |||
| public updatePillPosition(resizing: boolean): void { | |||
There was a problem hiding this comment.
to avoid a breaking change, we should keep the method and mark it deprecated
There was a problem hiding this comment.
Even though it was marked as internal?
There was a problem hiding this comment.
I think yes, @kyubisation your opinion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Closes #3364
Note for reviewers
I added a few comments to clarify the decisions I took during development