Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callbacks for Notfication Jumpmarks #131

Closed
marcodev01 opened this issue Aug 14, 2019 · 0 comments · Fixed by #211
Closed

Callbacks for Notfication Jumpmarks #131

marcodev01 opened this issue Aug 14, 2019 · 0 comments · Fixed by #211
Labels
comp: standard Issues related to @sbb-esta/angular standard design effort1: hours enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed prio4: low Should be done after all higher priorities are done

Comments

@marcodev01
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We have cases where we wan't to scroll and focus to a specfifc input element linked by jumpmarks. Unfortunately scroll or focus by jumpmarks of the notification component don't work with perfectscrollbar.

Describe the solution you'd like
To solve this problem jumpmarks should have optional callback methods as input to solve programatically user scroll and focus issues with third party libraries as ngx-perfect-scrollbar
@marcodev01 marcodev01 added the enhancement New feature or request label Aug 14, 2019
@kyubisation kyubisation self-assigned this Aug 27, 2019
@kyubisation kyubisation added comp: standard Issues related to @sbb-esta/angular standard design effort1: hours good first issue Good for newcomers help wanted Extra attention is needed prio4: low Should be done after all higher priorities are done labels Sep 9, 2019
@kyubisation kyubisation removed their assignment Sep 9, 2019
daniel-sc added a commit to daniel-sc/sbb-angular that referenced this issue Nov 4, 2019
@daniel-sc
feat(notification): add optional callbacks to jump marks
ed10da9 
Allow to perform specific actions on jump mark click.

closes sbb-design-systems#131
@daniel-sc daniel-sc mentioned this issue Nov 4, 2019
Merged
kyubisation pushed a commit that referenced this issue Nov 4, 2019
@daniel-sc @kyubisation
feat(public): add optional callbacks to jump marks in notification (#211
302dc24 
)

Allow to perform specific actions on jump mark click.

closes #131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: standard Issues related to @sbb-esta/angular standard design effort1: hours enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed prio4: low Should be done after all higher priorities are done
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(notification): add optional callbacks to jump marks daniel-sc/sbb-angular
2 participants
@kyubisation @marcodev01