Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Datepicker TitleCasePipe not configurable #226

Closed
daniel-sc opened this issue Nov 25, 2019 · 0 comments · Fixed by #227
Closed

Bug: Datepicker TitleCasePipe not configurable #226

daniel-sc opened this issue Nov 25, 2019 · 0 comments · Fixed by #227
Labels
bug Something isn't working comp: lean Issues related to @sbb-esta/angular lean design comp: standard Issues related to @sbb-esta/angular standard design effort1: hours help wanted Extra attention is needed prio4: low Should be done after all higher priorities are done

Comments

@daniel-sc
Copy link
Contributor

daniel-sc commented Nov 25, 2019 •
edited
Loading

Describe the bug
Currently the DateInput directive (used by the DatePicker) uses the TitleCasePipe to (re-)format the result of the formatted date (from DateAdapter). This makes it impossible to display e.g. the calendar week correctly ('\'KW\' w', provided via SBB_DATE_FORMATS).

See

sbb-angular/projects/sbb-esta/angular-public/datepicker/src/date-input/date-input.directive.ts

Line 209 in 8df17ce

private _titleCasePipe = new TitleCasePipe();

and

sbb-angular/projects/sbb-esta/angular-public/datepicker/src/date-input/date-input.directive.ts

Line 376 in 8df17ce

? this._titleCasePipe.transform(this.dateAdapter.format(value, this._dateFormats.dateInput))

Expected behavior
Either completely remove the TitleCasePipe or make it possible to disable this via a new input or by injecting a custom TitleCasePipe.

Screenshots
image
@daniel-sc daniel-sc added the bug Something isn't working label Nov 25, 2019
daniel-sc added a commit to daniel-sc/sbb-angular that referenced this issue Nov 25, 2019
@daniel-sc
fix(datepicker): configurable TitleCasePipe in DatePicker
b16756c 
Allow to customize usage of TitleCasePipe in DateInput/DatePicker by injecting it.

closes sbb-design-systems#226
@daniel-sc daniel-sc mentioned this issue Nov 25, 2019
Merged
@kyubisation kyubisation added comp: lean Issues related to @sbb-esta/angular lean design comp: standard Issues related to @sbb-esta/angular standard design effort1: hours help wanted Extra attention is needed prio4: low Should be done after all higher priorities are done labels Nov 25, 2019
daniel-sc added a commit to daniel-sc/sbb-angular that referenced this issue Nov 25, 2019
@daniel-sc
fix(datepicker): refactor usage of TitleCasePipe to DateAdapter
dcf1050 
Allow to customize usage of TitleCasePipe in DateInput/DatePicker by injecting custom DateAdapter.

closes sbb-design-systems#226
kyubisation pushed a commit that referenced this issue Nov 25, 2019
@daniel-sc @kyubisation
fix(datepicker): refactor usage of TitleCasePipe to DateAdapter (#227)
ca0f4fa 
Allow to customize usage of TitleCasePipe in DateInput/DatePicker by injecting custom DateAdapter.

closes #226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working comp: lean Issues related to @sbb-esta/angular lean design comp: standard Issues related to @sbb-esta/angular standard design effort1: hours help wanted Extra attention is needed prio4: low Should be done after all higher priorities are done
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(datepicker): configurable TitleCasePipe in DatePicker daniel-sc/sbb-angular
2 participants
@daniel-sc @kyubisation