Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(business): contextmenu #80

Closed
kyubisation opened this issue Jul 5, 2019 · 0 comments · Fixed by #163
Closed

feat(business): contextmenu #80

kyubisation opened this issue Jul 5, 2019 · 0 comments · Fixed by #163
Assignees
@daniele92vp
Labels
comp: lean Issues related to @sbb-esta/angular lean design effort2: days help wanted Extra attention is needed prio3: medium Should be done when time available

Comments

@kyubisation
Copy link
Collaborator

kyubisation commented Jul 5, 2019 •
edited
Loading

Design Spec: https://digital.sbb.ch/en/webapps/components/contextmenu (Section 4.2 Icon)
https://angular.app.sbb.ch/latest/content/IconContextMenuComponent

API Spec:

  • Selector: sbb-contextmenu
  • Contains <sbb-icon-context-menu>, which is wrapped by a button
  • Must contain a sbb-dropdown
  • The contextmenu opens on click
<sbb-contextmenu>
  <sbb-dropdown>
    <button sbbDropdownItem type="button" (click)="action1()">Action 1</button>
    <button sbbDropdownItem type="button" (click)="action2()">Action 2</button>
  </sbb-dropdown>
</sbb-contextmenu>
@kyubisation kyubisation added the help wanted Extra attention is needed label Jul 8, 2019
daniele92vp added a commit to daniele92vp/sbb-angular that referenced this issue Aug 26, 2019
@daniele92vp
feat(contextmenu)
e342a59 
closes (sbb-design-systems#80)
daniele92vp added a commit to daniele92vp/sbb-angular that referenced this issue Sep 4, 2019
@daniele92vp
feat(contextmenu)
bb11553 
closes (sbb-design-systems#80)
@kyubisation kyubisation added comp: lean Issues related to @sbb-esta/angular lean design effort2: days prio3: medium Should be done when time available labels Sep 10, 2019
kyubisation pushed a commit that referenced this issue Sep 12, 2019
@daniele92vp
feat(contextmenu)
d614224 
closes (#80)
@kyubisation kyubisation mentioned this issue Sep 12, 2019
Merged
kyubisation added a commit that referenced this issue Sep 12, 2019
@kyubisation
feat(business): implement contextmenu (#163)
23fea1f 
Closes #80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniele92vp daniele92vp

Labels
comp: lean Issues related to @sbb-esta/angular lean design effort2: days help wanted Extra attention is needed prio3: medium Should be done when time available
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(business): implement contextmenu sbb-design-systems/sbb-angular
2 participants
@kyubisation @daniele92vp