Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(business/button): add icon content child to component and template #188

Merged
merged 1 commit into from
Sep 30, 2019

Conversation

efux
Copy link
Contributor

@efux efux commented Sep 30, 2019

I added to necessary instructions directly to the business button. This hopefully displays the icons again. If I have time, I will someday refactor the stylings, so there is another template, but for the moment, I would just like to get it to work. So a bugfix release asap would be appreciated, otherwise I would have to rollback to an older version.

In my tests the directive

<button sbbButton mode="icon">
  <sbb-icon-arrow-right *sbbIcon></sbb-icon-arrow-right>
</button>

still did not work, but I hope this is due to my test setup. However,

<ng-template #icon>
  <sbb-icon-arrow-right></sbb-icon-arrow-right>
</ng-template>
<button sbbButton mode="icon" [icon]="icon">

works fine.

@kyubisation kyubisation merged commit 93307d0 into master Sep 30, 2019
@kyubisation kyubisation deleted the fix/business/icon-button branch September 30, 2019 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants