-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP SharkFinAgentType #101
base: master
Are you sure you want to change the base?
Conversation
initial PortfolioSharkFinAgentType
Good start. Is this still WIP? |
Yes. We can use this as the structure to build from. Once this is merged, the new AgentPopulation will be adapted to interact with this object instead of the HARK agents. |
simulate method for SHARKFIN needs to do 2 kinds of simulations, macro day and intraday
There's a merge conflict for this PR. |
I'll fix the conflict ASAP. This is a good start for SharkFinAgentType, but I think more needs to be done. Right now there is only one simulate method. Perhaps there should be 2. One for a macro day and one for an activity day so that we can have more fine tuning control of when changes to income are happening, when consumption is happening, and when normalization is happening. This also needs integration into the methods that are SHARK specific like attend and compute share demand. |
OK, super. Thank you! |
@sbenthall the discretize issue was fixed in #191 and already merged |
Oh, whoops. My bad, thanks. |
Initial PortfolioSharkFinAgentType
Addresses #85. More methods might be needed to interact with Agent Population and AgentSolution