Cloud Automation Support #247
Conversation
…ute simulations against a slurm cluster. Additional Code for Azure Service Bus enabled Market Class
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | Microsoft Azure Storage Account Key | fb0755d | cloud/automation/AMMPS_ONLY/LucasShark/slurmRunnerLucas.py | View secret |
| - | Microsoft Azure Storage Account Key | fb0755d | cloud/automation/AMMPS_ONLY/LucasShark/slurmRunnerLucasShark.py | View secret |
| - | Microsoft Azure Storage Account Key | fb0755d | cloud/automation/AMMPS_ONLY/LucasShark/slurmRunnerLucasSharkStats.py | View secret |
| - | Microsoft Azure Storage Account Key | fb0755d | cloud/automation/AMMPS_ONLY/slurmRunnerAMMPS.py | View secret |
| - | Microsoft Azure Storage Account Key | fb0755d | cloud/automation/simRunner.py | View secret |
| - | Microsoft Azure Storage Account Key | fb0755d | cloud/automation/simRunner.py | View secret |
| - | Microsoft Azure Storage Account Key | fb0755d | cloud/automation/simRunner.py | View secret |
| - | Microsoft Azure Storage Account Key | fb0755d | cloud/automation/simRunner.py | View secret |
| - | Microsoft Azure Storage Account Key | fb0755d | cloud/automation/simRunner.py | View secret |
| - | Microsoft Azure Storage Account Key | fb0755d | cloud/automation/simRunner.py | View secret |
| - | Microsoft Azure Storage Account Key | fb0755d | cloud/automation/slurmRunner.py | View secret |
| - | GitHub Access Token | fb0755d | cloud/node_config/01-os-config-alma-linux.sh | View secret |
| - | Microsoft Azure Storage Account Key | 3c80ca7 | cloud/automation/simRunner.py | View secret |
| - | Microsoft Azure Storage Account Key | 3c80ca7 | cloud/automation/slurmRunner.py | View secret |
| - | GitHub Access Token | 3c80ca7 | cloud/node_config/01-os-config-alma-linux.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
Hello @wjt5121 Thanks for this. But GitGuardian is warning that there are secret keys in this PR, which is open to the public Internet. Would it be possible to separate these out into a config file without the secrets in it, and then send us a config file with the real secrets in it? You may also want to change the 'secrets' that have now been made public... |
|
Oh yeah... duh... I totally forgot I had connection strings all over those run books. I've rotated the keys and will get it cleaned up and resubmit. |
|
Removed Secrets and updated runbook. |
1 . Provides the automated tools to create simulation configurations and execute simulations against a Slurm cluster.
2. Additional Code for Azure Service Bus enabled Market Class