Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cycles = 0 #268

Merged
merged 8 commits into from
Feb 8, 2024
Merged

cycles = 0 #268

merged 8 commits into from
Feb 8, 2024

Conversation

alanlujan91
Copy link
Collaborator

No description provided.

@alanlujan91
Copy link
Collaborator Author

Using dask to speed up numerical exercise; parallel processing of function calls scaled up to computer resources.

@sbenthall
Copy link
Owner

cool.

let me know when this is ready to merge.

@alanlujan91
Copy link
Collaborator Author

@sbenthall i removed some of your code, especially the plotting, to make this faster. Is that ok? Do we need some sort of plot for this?

@sbenthall
Copy link
Owner

i think the plotting was just an artifact; no worries

lucas0_agent_population_params.update(
{
"cycles": 0, # issue 186
"aNrmInitStd": 0.28901524, # calculated using dashboard from default init_portfolio stats
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be the aNrmInitMean ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't add this here, but I think it should be setting aNrmInitMean

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Would you mind correcting that? I would do it myself but it's in your personal PR.

"PermGroFac": 1.0,
"Rfree": 1.0,
### These are placeholders that will be set when the system is set up.
"CRRA": 5,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value is 6 in the Numerical notebook. Which do you mean?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is 5 in the default so let's go with 5

@sbenthall sbenthall mentioned this pull request Feb 5, 2024
7 tasks
@sbenthall
Copy link
Owner

is this ready to merge?

@alanlujan91
Copy link
Collaborator Author

Need to actually calculate aNrmInitMean, which notebook does this?

@sbenthall
Copy link
Owner

I don't think we've settled on a process for this.
There is code that does something like this in the numerical buffer stock and dashboard notebooks.
But there's nothing that says specifically:

  • here's the parameters we are committed to
  • here's the calculations we are doing to flesh out those parameters.

certainly open to improvements.

@alanlujan91
Copy link
Collaborator Author

Ok ready to review

@sbenthall
Copy link
Owner

Just to double check:
... are these dividend growth and stdev rates correct? i.e., did you use the same ones when calculating the target wealth?

https://github.com/sbenthall/SHARKFin/blob/master/simulate/run_any_simulation.py#L109-L118

honestly it might be better to have all these details settled in one document.

the configuration is scattered across many different points but we need a canonical description of what we're trying to do. This info will also go into the paper.

@alanlujan91
Copy link
Collaborator Author

@sbenthall on scaling... we can't scale income.... mNrm_next = a * R + 1*p_shk, we would need mNrm_next = a * R_scaled + 1/4 * p_shk_scaled

@sbenthall
Copy link
Owner

Could we:

  • start with a pLvl scaled down?
  • scale the income shocks down appropriately?

Not sure I'm following the logic here, but maybe you can run the question by Chris?

@alanlujan91
Copy link
Collaborator Author

@sbenthall ready to review

see macro/macro_parameters.py for new master list of parameters, annual and quarterly

@sbenthall
Copy link
Owner

Ok, merging now, thanks.

@sbenthall sbenthall merged commit bfdbc8b into sbenthall:master Feb 8, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants