moved metrics in core as union module #233
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
intsynko
commented
Apr 7, 2022
•
intsynko
commented
- перенесли класс метрики из smart_kit в класс мониторинга в core и поменяли везде импорты метрик на импорт мониторинга
- обернули синглтон инстанс в Proxy класс - это что то типо адаптера, он пробрасывает все вызовы методов в прикрепленный инстанс мониторинга и может подменять один инстанс мониторинга другим. Так же может с тем чтобы уже примененные декораторы вызывались с нужным инстансом монитоирнга
- подрутили тесты для отображения для чего это было нужно и как с этим теперь надо работать
SyrexMinus
previously approved these changes
Apr 7, 2022
intsynko
force-pushed
the
feature/new_metrics
branch
from
267b68b to
259e6f8
Compare
bart02
force-pushed
the
feature/new_metrics
branch
from
c1b3b4d to
e75f346
Compare
bart02
previously approved these changes
Apr 11, 2022
dangerink
reviewed
Apr 12, 2022
core/monitoring/monitoring.py
Outdated
| def got_histogram(self, param): | ||
| def decor_(func): | ||
| def wrap(*args, **kwargs): | ||
| wrapped_func = self.instance.got_histogram(param)(func) |
There was a problem hiding this comment.
got_histogram 2 параметра же принимает?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.