Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 13 Dark mode support in AlertView #298

Merged
merged 4 commits into from
Feb 17, 2020
Merged

Conversation

ftp27
Copy link
Contributor

@ftp27 ftp27 commented Sep 17, 2019

There is a small fix to support dark background in AlertView and few changes in Example storyboard to make it look nicer in iOS 13.

@jaketesler
Copy link

Is it possible for someone to merge this PR + issue a new release on GH with the fix?

@andre719mv
Copy link

Also it will be good to fix background and border for textfield in dark mode.

@jaketesler
Copy link

Any updates on this PR? :)

@ftp27
Copy link
Contributor Author

ftp27 commented Jan 13, 2020

@andre719mv Now it works, I guess )

@jaketesler
Copy link

jaketesler commented Feb 7, 2020

Can someone merge this + release an update? Our app could really use dark mode alert support 💯

cc @sberrevoets @andre719mv

@sberrevoets
Copy link
Owner

Sorry, time is in short supply for me nowadays. I'll do my best to get to this soon but until then I recommend using this branch.

Copy link
Owner

@sberrevoets sberrevoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general - if you could address these 2 comments I'll merge and issue an update

Example/Base.lproj/Main.storyboard Outdated Show resolved Hide resolved
Source/Text Fields/TextFieldCell.swift Outdated Show resolved Hide resolved
@ftp27
Copy link
Contributor Author

ftp27 commented Feb 17, 2020

@sberrevoets Is it ok now?

@sberrevoets sberrevoets merged commit 9adebbe into sberrevoets:master Feb 17, 2020
@sberrevoets
Copy link
Owner

Thanks, version 11 is now available through CocoaPods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants