Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with token removal #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

brogoz
Copy link

@brogoz brogoz commented Jan 13, 2011

Hey,

I found a potential bug in the js. If you tried to remove the token (by clicking on 'x' or by using 'backspace') wrong token was removed from hidden input value (on jQuery v1.4.2).

Check and if you agree pull the changes.

Thanks for the great plugin,
Bartek

@Samrat-Saha-Sammy
Copy link

I Just Downloaded the Plugin from the main site (http://sbfaulkner.github.io/jquery.token-field/demo.html) and still got the error,
As i have fixed the bug myself, so want to let every one know the solution.

Line no. 87
BEFORE : "values.splice(0, 0, $(this).val());" 👎
AFTER(fixed) : "values.splice(-1, 0, $(this).val());" 👍

:
This will also solve the reverse value in hidden field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants