Adapt usage of log_abs_det_jacobian for torch>=1.8 #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependence on torch 1.8 makes sense because the current
sbi
version, which we want to use, depends on it.With this change we get rid of the helper function
get_log_abs_det_jacobian
that was distinguishing between the behavior before and after torch 1.8 and was doing the summation explicitly.Details:
torch>=1.8
the output oflog_prob
andlog_abs_det_jacobian
changes: when the input has several parameter dimensions the output will keep those dimensions and we would have to sum over them by hand to get the joint log_prob over parameter dimensions.IndependentTransform
as a wrapperSee also #15