Fix latest sample init strategy for snle and snre. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested the changes and everything seems to work smoothly now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #56
after round 2, we are using the latest posterior samples from the previous round as inits for the current round.
The
posterior._mcmc_init_paramsare set to the latest samples at the end of thesamplemethod.With the new sampler interface, however, we are creating a new posterior object at every iteration so that the latest samples are not set.
In this fix, we copy the
posterior._mcmc_init_paramsfrom the proposal (posterior from previous round) to the newly created posterior of the current round.Independent from #56 , I here also adapt to the new z-scoring api (separate commit).