Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbi.mcmc to sbi.samplers.mcmc #59

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

bkmi
Copy link
Contributor

@bkmi bkmi commented Jun 19, 2023

I haven't tested it, I only updated the imports

@bkmi bkmi changed the title update to confirm with sbi interface update to conform with sbi interface Jun 19, 2023
@jan-matthis jan-matthis requested a review from janfb June 26, 2023 20:29
Copy link
Contributor

@janfb janfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is the old API and your changes are correct. Thanks for fixing this!

@janfb
Copy link
Contributor

janfb commented Jun 27, 2023

I will add a test and fix a couple of more missing API changes in a separate PR @jan-matthis

@janfb janfb mentioned this pull request Jun 27, 2023
@jan-matthis jan-matthis changed the title update to conform with sbi interface Update sbi.mcmc to sbi.samplers.mcmc Jun 28, 2023
@jan-matthis jan-matthis merged commit 9b16974 into sbi-benchmark:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants