Fix bug in importance sampled posterior (#1081)

* Added theory section for importance sampling tutorial. * Added manual importance sampling to tutorial. * Finished importance sampling tutorial. * Fixed bug in sir, where the oversampling_rate would not be passed to the sir function.
sbi-dev · Apr 2, 2024 · d3b458b · d3b458b
1 parent b074c66
commit d3b458b
Show file tree

Hide file tree

Showing 2 changed files with 24,253 additions and 1 deletion.
diff --git a/sbi/inference/posteriors/importance_posterior.py b/sbi/inference/posteriors/importance_posterior.py
@@ -253,7 +253,7 @@ def _sir_sample(
             self.potential_fn,
             proposal=self.proposal,
             num_samples=num_samples,
-            oversampling_factor=oversampling_factor,
+            num_candidate_samples=oversampling_factor,
             show_progress_bars=show_progress_bars,
             max_sampling_batch_size=max_sampling_batch_size,
             device=self._device,

diff --git a/tutorials/17_importance_sampled_posteriors.ipynb b/tutorials/17_importance_sampled_posteriors.ipynb