-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better default arguments for MCMC, SNLE, SNPE. #910
Comments
Note: Update: thinning does not seem to be the problem. if thinning is small it just increases the likelihood of hitting an inf or NaN value. |
Additional context: The default parameters are defined here. Following discussion in #924 - a good suggestion for the default parameters for |
Once #908 is addressed there might be even better default args |
@famura can you please add the new info about best practice regarding |
Sure, where do you want me to add it? in the top level class? |
No, just post a link to the resource giving more details. Then we can use it when we decide for better default args later |
So, @felixp8 and I came across this post. Moreover, @michaeldeistler and @sethaxen discussed with the somewhat confident result that we can set thinning to 1 by default. However, since this will most likely lead to results that differ from the benchmark, we came up with the solution that we set Is that the kind of information you were looking for? |
On a different note @sethaxen said that |
TODO:
A bit unrelated but I also suggest switching training defaults to
|
The text was updated successfully, but these errors were encountered: