Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ruff linting errors 🏅 #959

Closed
janfb opened this issue Feb 28, 2024 · 0 comments · Fixed by #978
Closed

fix ruff linting errors 🏅 #959

janfb opened this issue Feb 28, 2024 · 0 comments · Fixed by #978
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request hackathon karma Karma issues: potentially annoying but very important issues

Comments

@janfb
Copy link
Contributor

janfb commented Feb 28, 2024

In #955 we introduced ruff for formatting and linting (replacing black, isort, flake8 etc).

In the pre-commit hook, ruff lint . is currently commented out because it causes hundreds of errors / violations of the linting rules.

The PR fixing this issue would run ruff lint . locally and fix all of these errors, ideally in separate commits for each type of problems. The most prominent problems are

  • E501 Line too long (>88)
  • B008 Do not perform function in argument defaults
  • B006 Do not use mutable data structures for argument defaults
  • UP006, UP007 wrong type annotations, e.g., Tuple instead of tuple.

Most of them are easy to fix because ruff gives explicit hints.

This is an annoying thing to fix. The contributor fixing this will be honored publicly 🏅

@janfb janfb added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request hackathon labels Feb 28, 2024
@janfb janfb added this to the Hackathon 2024 milestone Feb 28, 2024
@janfb janfb added the karma Karma issues: potentially annoying but very important issues label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request hackathon karma Karma issues: potentially annoying but very important issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant