-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace prepare_for_sbi in tutorials #1013
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1013 +/- ##
=======================================
Coverage 76.37% 76.37%
=======================================
Files 84 84
Lines 6507 6507
=======================================
Hits 4970 4970
Misses 1537 1537
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an issue has to be raised for this notebook as it throws an error but not related to replace prepare_for_sbi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A separate issue has to be raised for notebook 14_iid as it throws an error but not related to replace prepare_for_sbi
There is a conflict with
Alternatively, as resolving conflicts in notebooks can be painful, you could open a new branch from most recent main and apply your changes from scratch. Let me know if you have questions. |
* update zuko to 1.1.0 * test zuko_gmm commit * build_zuko_nsf added * add build_zuko_naf, update test * add license change to pr template. * CLN pyproject.toml (#1009) * CLN pyproject.toml * CLN optional deps comment * CLN alphabetical order * fix x_o and broken link tutorial 7 (#1003) * fix x_o and broken link tutorial 7 * typo in title * suppress plotting output --------- Co-authored-by: Matthijs <matthijs@example.com> * replace prepare_for_sbi in tutorials (#1013) * add zuko density estimators * not working gmm * update tests for PR * update PR for pyright * resolve pyright * add reportArgumentType * resolve pyright issue * resolve all issues pyright * resolve pyright * add typing and docstring * add functions from factory to test * remove comment mdn file * add docstrings flow file * add docstring in density_estimator_test.py * Update sbi/neural_nets/flow.py Co-authored-by: Sebastian Bischoff <sebastian@salzreute.de> * Update sbi/neural_nets/flow.py Co-authored-by: Sebastian Bischoff <sebastian@salzreute.de> * Update sbi/neural_nets/flow.py Co-authored-by: Sebastian Bischoff <sebastian@salzreute.de> * removed pyright --------- Co-authored-by: bkmi <12955549+bkmi@users.noreply.github.com> Co-authored-by: Nastya Krouglova <nastyakrouglova@Nastyas-MacBook-Pro.local> Co-authored-by: Jan Boelts <jan.boelts@mailbox.org> Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com> Co-authored-by: Matthijs Pals <34062419+Matthijspals@users.noreply.github.com> Co-authored-by: Matthijs <matthijs@example.com> Co-authored-by: zinaStef <49067201+zinaStef@users.noreply.github.com> Co-authored-by: Sebastian Bischoff <sebastian@salzreute.de>
* update zuko to 1.1.0 * test zuko_gmm commit * build_zuko_nsf added * add build_zuko_naf, update test * add license change to pr template. * CLN pyproject.toml (#1009) * CLN pyproject.toml * CLN optional deps comment * CLN alphabetical order * fix x_o and broken link tutorial 7 (#1003) * fix x_o and broken link tutorial 7 * typo in title * suppress plotting output --------- Co-authored-by: Matthijs <matthijs@example.com> * replace prepare_for_sbi in tutorials (#1013) * add zuko density estimators * not working gmm * update tests for PR * update PR for pyright * resolve pyright * add reportArgumentType * resolve pyright issue * resolve all issues pyright * resolve pyright * add typing and docstring * add functions from factory to test * remove comment mdn file * add docstrings flow file * add docstring in density_estimator_test.py * Update sbi/neural_nets/flow.py Co-authored-by: Sebastian Bischoff <sebastian@salzreute.de> * Update sbi/neural_nets/flow.py Co-authored-by: Sebastian Bischoff <sebastian@salzreute.de> * Update sbi/neural_nets/flow.py Co-authored-by: Sebastian Bischoff <sebastian@salzreute.de> * removed pyright --------- Co-authored-by: bkmi <12955549+bkmi@users.noreply.github.com> Co-authored-by: Nastya Krouglova <nastyakrouglova@Nastyas-MacBook-Pro.local> Co-authored-by: Jan Boelts <jan.boelts@mailbox.org> Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com> Co-authored-by: Matthijs Pals <34062419+Matthijspals@users.noreply.github.com> Co-authored-by: Matthijs <matthijs@example.com> Co-authored-by: zinaStef <49067201+zinaStef@users.noreply.github.com> Co-authored-by: Sebastian Bischoff <sebastian@salzreute.de>
* Zuko density estimators (#1088) * update zuko to 1.1.0 * test zuko_gmm commit * build_zuko_nsf added * add build_zuko_naf, update test * add license change to pr template. * CLN pyproject.toml (#1009) * CLN pyproject.toml * CLN optional deps comment * CLN alphabetical order * fix x_o and broken link tutorial 7 (#1003) * fix x_o and broken link tutorial 7 * typo in title * suppress plotting output --------- Co-authored-by: Matthijs <matthijs@example.com> * replace prepare_for_sbi in tutorials (#1013) * add zuko density estimators * not working gmm * update tests for PR * update PR for pyright * resolve pyright * add reportArgumentType * resolve pyright issue * resolve all issues pyright * resolve pyright * add typing and docstring * add functions from factory to test * remove comment mdn file * add docstrings flow file * add docstring in density_estimator_test.py * Update sbi/neural_nets/flow.py Co-authored-by: Sebastian Bischoff <sebastian@salzreute.de> * Update sbi/neural_nets/flow.py Co-authored-by: Sebastian Bischoff <sebastian@salzreute.de> * Update sbi/neural_nets/flow.py Co-authored-by: Sebastian Bischoff <sebastian@salzreute.de> * removed pyright --------- Co-authored-by: bkmi <12955549+bkmi@users.noreply.github.com> Co-authored-by: Nastya Krouglova <nastyakrouglova@Nastyas-MacBook-Pro.local> Co-authored-by: Jan Boelts <jan.boelts@mailbox.org> Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com> Co-authored-by: Matthijs Pals <34062419+Matthijspals@users.noreply.github.com> Co-authored-by: Matthijs <matthijs@example.com> Co-authored-by: zinaStef <49067201+zinaStef@users.noreply.github.com> Co-authored-by: Sebastian Bischoff <sebastian@salzreute.de> * merge * hate * merge * merge * merge * merge * MERGE * remove cnf * implement changes Jan * Update sbi/neural_nets/factory.py Co-authored-by: Jan <janfb@users.noreply.github.com> * resolve issues Jan * undo changes to tutorials folder. * sort dependencies. --------- Co-authored-by: bkmi <12955549+bkmi@users.noreply.github.com> Co-authored-by: Nastya Krouglova <nastyakrouglova@Nastyas-MacBook-Pro.local> Co-authored-by: Jan Boelts <jan.boelts@mailbox.org> Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com> Co-authored-by: Matthijs Pals <34062419+Matthijspals@users.noreply.github.com> Co-authored-by: Matthijs <matthijs@example.com> Co-authored-by: zinaStef <49067201+zinaStef@users.noreply.github.com> Co-authored-by: Sebastian Bischoff <sebastian@salzreute.de> Co-authored-by: Jan <janfb@users.noreply.github.com>
It replaces in the relevant tutorial notebooks the
simulator, prior = prepare_for_sbi(custom_simulator, custom_prior)
byFixes #752
Checklist:
guidelines
with
pytest.mark.slow
.guidelines
main
(or there are no conflicts withmain
)