-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache dependencies in Github Action (#1027) #1028
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1028 +/- ##
=======================================
Coverage 76.37% 76.37%
=======================================
Files 84 84
Lines 6507 6507
=======================================
Hits 4970 4970
Misses 1537 1537
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a great way to make the CI run faster. But I would like to get @tomMoral feedback as well.
Caching was successful in https://github.com/sbi-dev/sbi/actions/runs/8343959002/job/22835278231. It's about 380 MB it will now download from Github's Cache server in each CI run, should take 2sec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a small nitpick for simplication, as you don't really need versionised cache based on pyporject.toml
.
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! thanks 🙏
With this change, Github Action will look for a cached dependency installation based on the same
pyproject.toml
, load it from its cache and not need to install it again. This should make all CI tests run faster.Checklist
guidelines
main
(or there are no conflicts withmain
)