Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues pyright raises on newer Python versions #1108

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

Baschdl
Copy link
Contributor

@Baschdl Baschdl commented Mar 22, 2024

Pyright raised errors in newer Python versions (e.g. 3.10) which it didn't do in our CI pipeline running on 3.8. First step towards #1102

Checklist

  • I agree with re-licensing my contribution from AGPLv3 to Apache-2.0.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.83%. Comparing base (4c2f71e) to head (cb5663c).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1108      +/-   ##
==========================================
+ Coverage   76.37%   76.83%   +0.45%     
==========================================
  Files          84       91       +7     
  Lines        6507     6588      +81     
==========================================
+ Hits         4970     5062      +92     
+ Misses       1537     1526      -11     
Flag Coverage Δ
unittests 76.83% <100.00%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@manuelgloeckler manuelgloeckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how this fixes the issue, but I will approve it so that you can merge it in your branch.

@Baschdl Baschdl merged commit eeaf891 into sbi-dev:main Mar 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants