Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruff linting hook, fix line lengths. #1113

Merged
merged 1 commit into from
Mar 25, 2024
Merged

ruff linting hook, fix line lengths. #1113

merged 1 commit into from
Mar 25, 2024

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Mar 25, 2024

  • ruff linting was not working during CI because of wrong kwarg diff (my bad).
  • too long line were pushed into main as a consequence.

both fixed with this commit.

@janfb janfb self-assigned this Mar 25, 2024
@janfb janfb added the bug Something isn't working label Mar 25, 2024
@janfb janfb requested a review from michaeldeistler March 25, 2024 13:36
@janfb janfb force-pushed the fix-ruff-ci-and-line-lenghts branch from 665d12b to 728ea4d Compare March 25, 2024 16:48
@janfb
Copy link
Contributor Author

janfb commented Mar 25, 2024

Merging this in spite of formatting errors to avoid merge conflicts in coming PRs.

@janfb janfb merged commit c4160f0 into main Mar 25, 2024
2 of 3 checks passed
@janfb janfb deleted the fix-ruff-ci-and-line-lenghts branch March 25, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeldeistler michaeldeistler michaeldeistler approved these changes

Assignees

@janfb janfb

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janfb @michaeldeistler