New file structure for neural networks

[michaeldeistler]

File structure

Imports

The following imports work:

from sbi.neural_nets import posterior_nn

from sbi.neural_nets.net_builders import build_maf
from sbi.neural_nets.embedding_nets import FCEmbedding
from sbi.neural_nets.estimators import MixedDensityEstimator

The following imports do not work:

from sbi.neural_nets import build_maf
from sbi.neural_nets import FCEmbedding
from sbi.neural_nets import MixedDensityEstimator

[janfb]

Great! I left some comments regarding error handling and naming.

[janfb]

Great! Thanks a lot!

[codecov]

Codecov Report

Attention: Patch coverage is 93.23308% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.18%. Comparing base (04c7b04) to head (7c2e945).
Report is 1 commits behind head on main.

Files	Patch %	Lines
sbi/neural_nets/__init__.py	57.14%	6 Missing ⚠️
sbi/neural_nets/embedding_nets/fully_connected.py	84.61%	2 Missing ⚠️
...eural_nets/embedding_nets/permutation_invariant.py	96.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1237      +/-   ##
==========================================
- Coverage   86.11%   78.18%   -7.93%     
==========================================
  Files         110      114       +4     
  Lines        8635     8669      +34     
==========================================
- Hits         7436     6778     -658     
- Misses       1199     1891     +692     

Flag	Coverage Δ
unittests	78.18% <93.23%> (-7.93%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
sbi/inference/fmpe/fmpe_base.py	94.33% <100.00%> (+0.05%)	⬆️
...inference/potentials/likelihood_based_potential.py	100.00% <100.00%> (ø)
sbi/inference/snle/mnle.py	85.36% <100.00%> (-7.32%)	⬇️
sbi/inference/snle/snle_base.py	93.93% <100.00%> (+0.06%)	⬆️
sbi/inference/snpe/snpe_base.py	91.66% <100.00%> (+0.04%)	⬆️
sbi/neural_nets/embedding_nets/__init__.py	100.00% <100.00%> (ø)
sbi/neural_nets/embedding_nets/cnn.py	100.00% <100.00%> (ø)
sbi/neural_nets/estimators/__init__.py	100.00% <100.00%> (ø)
sbi/neural_nets/estimators/score_estimator.py	92.89% <100.00%> (+0.39%)	⬆️
sbi/neural_nets/estimators/shape_handling.py	91.66% <ø> (ø)
... and 12 more

... and 26 files with indirect coverage changes