-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: automatic nb stripping and pypi upload #1267
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1267 +/- ##
===========================================
- Coverage 89.24% 78.28% -10.96%
===========================================
Files 119 119
Lines 8691 8698 +7
===========================================
- Hits 7756 6809 -947
- Misses 935 1889 +954
Flags with carried forward coverage won't be shown. Click here to find out more. |
695d6d4
to
3101e8f
Compare
3101e8f
to
2417963
Compare
2417963
to
919e89e
Compare
My fist approach was to using the full tutorial template from https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/ With this approach, we would make a test release on every push to A solution would be using Thus, I suggest that we "just" use a GH Action triggered when we do a manual release via GitHub (bump version manually, update the changelog, paste changelog into release section and create a tag). This action will build the |
919e89e
to
cb244cb
Compare
cb244cb
to
4971863
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Questions and comments below :)
4971863
to
5f5cf9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Late to the party but it looks super nice :)
sbi
PyPI projectRelevant links