Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add readme intro to docs landing page #1272

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Sep 6, 2024

At the moment, the docs website landing page starts a bit abruptly directly with the code snippet.

I think it is nice to have the same short intro text that we use in the updated readme as well.

What do you think?

In the future it would be nice to show a plot there as well.

@janfb janfb added the documentation Improvements or additions to documentation label Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.28%. Comparing base (becc93c) to head (4e9f71f).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1272       +/-   ##
===========================================
- Coverage   89.24%   78.28%   -10.96%     
===========================================
  Files         119      119               
  Lines        8691     8698        +7     
===========================================
- Hits         7756     6809      -947     
- Misses        935     1889      +954     
Flag Coverage Δ
unittests 78.28% <ø> (-10.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 33 files with indirect coverage changes

Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the additional info on the docs landing page. Thanks!

README.md Outdated
@@ -14,8 +14,8 @@
both researchers and practitioners. Whether you need fine-grained control or an
easy-to-use interface, `sbi` has you covered.

With `sbi`, you can perform simulation-based inference (SBI) using a Bayesian approach:
Given a simulator that models a real-world process, SBI estimates the full posterior
With `sbi`, you can perform parameter inference using a Bayesian approach: Given a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe even just using Bayesian inference? No strong opinions though.

@janfb janfb force-pushed the refactor-landing-page branch from 4e9f71f to 84f1849 Compare September 9, 2024 12:35
@janfb janfb merged commit dbcd06b into main Sep 9, 2024
2 of 4 checks passed
@janfb janfb deleted the refactor-landing-page branch September 9, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants