Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conditional posterior shape and device bugs. #1373

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Jan 20, 2025

There were a couple of bugs when using the MCMCPosterior with a conditioned_potential, which are fixed in this PR.

fixes #1364

@janfb janfb requested a review from michaeldeistler January 20, 2025 17:29
Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.41%. Comparing base (d3f22b5) to head (48747f0).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...inference/potentials/likelihood_based_potential.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1373       +/-   ##
===========================================
- Coverage   89.40%   78.41%   -11.00%     
===========================================
  Files         118      118               
  Lines        8715     8784       +69     
===========================================
- Hits         7792     6888      -904     
- Misses        923     1896      +973     
Flag Coverage Δ
unittests 78.41% <42.85%> (-11.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sbi/utils/sbiutils.py 78.11% <ø> (-8.68%) ⬇️
...inference/potentials/likelihood_based_potential.py 68.13% <42.85%> (-31.87%) ⬇️

... and 32 files with indirect coverage changes

@janfb janfb merged commit 448cef2 into main Jan 22, 2025
5 of 6 checks passed
@janfb janfb deleted the fix-map-gpu-bug branch January 22, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAP estimate does not work for conditional posterior
2 participants