Skip to content

fixed log_prob bug in snre #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2020
Merged

fixed log_prob bug in snre #280

merged 1 commit into from
Jul 30, 2020

Conversation

@michaeldeistler
Copy link
Contributor

@michaeldeistler michaeldeistler commented Jul 30, 2020 •
edited
Loading

  1. Warning for unnormalized log_prob was raised for SNRE_A but should be for SNRE_B
  2. fixed constant log_prob of SNRE, see Add missing type imports + make compatible for Python 3.6 #275
  3. Reduced allowed threshold for DKL (old value had been picked for 3D example and a different likelihood).

Feel free to merge.

@michaeldeistler michaeldeistler mentioned this pull request Jul 30, 2020
Merged
@jan-matthis jan-matthis merged commit f21d910 into main Jul 30, 2020
@janfb janfb deleted the fix-sre-log-prob branch August 15, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan-matthis jan-matthis Awaiting requested review from jan-matthis

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michaeldeistler @jan-matthis