Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow continuation of MCMC chains when using latest_sample #348

Merged
merged 2 commits into from
Sep 27, 2020

Conversation

jan-matthis
Copy link
Contributor

@jan-matthis jan-matthis commented Sep 27, 2020

While latest_sample was implemented, it was transferred from the proposal distribution to the posterior object returned by inference which made it impossible to be used. This is addressed in this PR.

@jan-matthis jan-matthis force-pushed the mcmc_latest_sample_init branch from 3250b06 to 76908b6 Compare September 27, 2020 11:07
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2020

Codecov Report

Merging #348 into main will decrease coverage by 0.14%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
- Coverage   74.23%   74.09%   -0.15%     
==========================================
  Files          49       49              
  Lines        2826     2841      +15     
==========================================
+ Hits         2098     2105       +7     
- Misses        728      736       +8     
Flag Coverage Δ
#unittests 74.09% <50.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sbi/inference/posteriors/base_posterior.py 64.59% <33.33%> (-0.32%) ⬇️
sbi/inference/snle/snle_base.py 95.18% <50.00%> (-1.12%) ⬇️
sbi/inference/snpe/snpe_base.py 93.26% <50.00%> (-0.85%) ⬇️
sbi/inference/snre/snre_base.py 94.84% <50.00%> (-0.95%) ⬇️
sbi/mcmc/init_strategy.py 37.50% <50.00%> (+4.16%) ⬆️
sbi/mcmc/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 924ca57...76908b6. Read the comment docs.

@jan-matthis jan-matthis merged commit d0fe846 into main Sep 27, 2020
@jan-matthis jan-matthis deleted the mcmc_latest_sample_init branch January 28, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants