Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix warnings for multi D x #361

Merged
merged 2 commits into from
Oct 8, 2020
Merged

fix warnings for multi D x #361

merged 2 commits into from
Oct 8, 2020

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Oct 8, 2020 •
edited
Loading

  • add assert against multi D x for SNPE and SNRE
  • catch RuntimeError and give debug hint for multi D x without proper embedding net in SNPE
  • small fix in user inputs

closes #351
closes #357
relates to #360

@janfb janfb added the documentation Improvements or additions to documentation label Oct 8, 2020
@janfb janfb added this to the Sustainable architecture milestone Oct 8, 2020
@janfb janfb self-assigned this Oct 8, 2020
@janfb janfb requested review from alvorithm and michaeldeistler and removed request for alvorithm October 8, 2020 06:57
@codecov-io
Copy link

codecov-io commented Oct 8, 2020 •
edited
Loading

Codecov Report

Merging #361 into main will increase coverage by 0.04%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
+ Coverage   74.09%   74.13%   +0.04%     
==========================================
  Files          49       49              
  Lines        2841     2842       +1     
==========================================
+ Hits         2105     2107       +2     
+ Misses        736      735       -1
Flag Coverage Δ
#unittests 74.13% <94.73%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sbi/utils/sbiutils.py 81.90% <ø> (-0.51%) ⬇️
sbi/user_input/user_input_checks.py 89.74% <88.88%> (-0.06%) ⬇️
sbi/inference/snle/snle_base.py 96.34% <100.00%> (+1.16%) ⬆️
sbi/inference/snpe/snpe_base.py 93.13% <100.00%> (-0.14%) ⬇️
sbi/inference/snre/snre_base.py 95.78% <100.00%> (+0.94%) ⬆️
sbi/utils/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0fe846...6ee4d26. Read the comment docs.

michaeldeistler
michaeldeistler reviewed Oct 8, 2020
View reviewed changes
Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Couple of minor things in comments.

sbi/inference/snre/snre_base.py Outdated Show resolved Hide resolved
sbi/user_input/user_input_checks.py Outdated Show resolved Hide resolved
@janfb
fix handling of multi dimensional x.
c0579a3 
* add assert to SNLE and SNRE that multiD x does not work.
* add method for SNPE to check for appropriate embedding net and give debug hint.
* adapt tests.
@janfb janfb merged commit ac2459a into main Oct 8, 2020
@janfb janfb deleted the fix-warnings branch October 8, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeldeistler michaeldeistler michaeldeistler left review comments

@alvorithm alvorithm Awaiting requested review from alvorithm

Assignees

@janfb janfb

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
Sustainable architecture
3 participants
@janfb @codecov-io @michaeldeistler