Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing call to infer in the first snippet of the home page #370

Merged
merged 2 commits into from
Oct 19, 2020

Conversation

glouppe
Copy link
Contributor

@glouppe glouppe commented Oct 19, 2020

I believe the simulator and prior arguments to infer are swapped in the example from the home page. Cheers!

@codecov-io
Copy link

Codecov Report

Merging #370 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #370   +/-   ##
=======================================
  Coverage   74.13%   74.13%           
=======================================
  Files          49       49           
  Lines        2842     2842           
=======================================
  Hits         2107     2107           
  Misses        735      735           
Flag Coverage Δ
#unittests 74.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b409a31...f3efdfc. Read the comment docs.

@jan-matthis
Copy link
Contributor

Oh, true, the arguments were swapped. Thanks a lot for catching this and sending a PR!

@jan-matthis jan-matthis merged commit a9048e9 into sbi-dev:main Oct 19, 2020
jan-matthis added a commit that referenced this pull request Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants