Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

z-score only using training data #411

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Conversation

michaeldeistler
Copy link
Contributor

We currently infer the mean and std of our data from all datapoints, including the validation set.

It is good practice to consider the mean and std as model parameters and therefore use only the training data to identify the mean and std.

See #393

@michaeldeistler michaeldeistler force-pushed the z-score-on-train-new branch 2 times, most recently from dd92a86 to add4acd Compare January 21, 2021 17:50
@codecov-io
Copy link

Codecov Report

Merging #411 (d8030aa) into main (39d6954) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #411   +/-   ##
=======================================
  Coverage   82.77%   82.77%           
=======================================
  Files          50       50           
  Lines        3187     3187           
=======================================
  Hits         2638     2638           
  Misses        549      549           
Flag Coverage Δ
unittests 82.77% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sbi/inference/snle/snle_base.py 97.77% <100.00%> (ø)
sbi/inference/snpe/snpe_base.py 93.38% <100.00%> (ø)
sbi/inference/snre/snre_base.py 97.08% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39d6954...d8030aa. Read the comment docs.

Copy link
Contributor

@janfb janfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@michaeldeistler michaeldeistler merged commit ab42a3c into main Jan 22, 2021
@janfb janfb deleted the z-score-on-train-new branch January 29, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants