Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiprocessing pbar #421

Merged
merged 3 commits into from
Jan 30, 2021
Merged

Fix multiprocessing pbar #421

merged 3 commits into from
Jan 30, 2021

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Jan 29, 2021 •
edited
Loading

closes #418
closes #419

@janfb janfb added the performance Everything related to performance label Jan 29, 2021
@janfb janfb self-assigned this Jan 29, 2021
@janfb janfb force-pushed the fix-multiprocessing-pbar branch from 09d0b17 to aa5a1b3 Compare January 29, 2021 14:32
michaeldeistler
michaeldeistler reviewed Jan 29, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
michaeldeistler
michaeldeistler approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made minor comments, otherwise good to go!

@janfb janfb force-pushed the fix-multiprocessing-pbar branch from aa5a1b3 to 93cd2a4 Compare January 29, 2021 14:53
@janfb janfb merged commit 5e71a43 into main Jan 30, 2021
@janfb janfb deleted the fix-multiprocessing-pbar branch January 30, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeldeistler michaeldeistler michaeldeistler approved these changes

@jan-matthis jan-matthis Awaiting requested review from jan-matthis

Assignees

@janfb janfb

Labels
performance Everything related to performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix progress bar and simulation batch size in simulate_in_batches Update joblib to solve pickling problems?
2 participants
@janfb @michaeldeistler