2nd try: Adding the ability to pass dataloader related kwargs in SNPE, SNRE and SNLE #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c. These dataloader_kwargs are used to create the train and val dataloaders in snpe_base, snre_base and snle_base
janfb
approved these changes
Mar 3, 2021
|
It now has a lot of code repetition in the inference classes, so we might think about refactoring and moving the data loader generation to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added dataloader_kwargs parameter to snle_a, snre_a, snre_b and snpe_c. These dataloader_kwargs are used to create the train and val dataloaders in snpe_base, snre_base and snle_base
@janfb I closed the previous MR, merged the current sbi main into my fork, and put the dataloader_kwargs related changes. I have avoided any formatting changes (that caused problems last time) - let me know if this looks ok :)
Closing #415