-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mnle as model class to snle #638
Conversation
Codecov Report
@@ Coverage Diff @@
## main #638 +/- ##
==========================================
+ Coverage 74.81% 76.53% +1.71%
==========================================
Files 75 77 +2
Lines 5667 5826 +159
==========================================
+ Hits 4240 4459 +219
+ Misses 1427 1367 -60
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
de47091
to
595a354
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the implementation a lot, thanks! I left some comments below
7912e3c
to
8e464b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Only minor comments below. Good to go once they are addressed.
* set default tensor locally to reach fixtures.
this provides easy access to Mixed Neural Likelihood Estimation (MNLE) in
sbi
: MNLE is a child of SNLE and can be used by callingMNLE()
and otherwise using the same API as withSNLE
:It is implemented as a single density estimator class that has two separate nets for discrete and continuous data, but trains them with a single
loss
call, i.e., using the usualSNLE
train
method (thanks to @michaeldeistler for the idea).It requires a separate
mixed_likelihood_estimator_based_potential
because it implements its ownlog_prob
for iid-x to get some speed up during MCMC.Tasks: