Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

force_first_round_loss=True for SNPE-A #729

Merged
merged 1 commit into from
Aug 24, 2022
Merged

force_first_round_loss=True for SNPE-A #729

merged 1 commit into from
Aug 24, 2022

Conversation

michaeldeistler
Copy link
Contributor

SNPE-A is always trained with Maximum-likelihood, so force_first_round_loss=True always.

@michaeldeistler michaeldeistler requested a review from janfb August 23, 2022 10:26
janfb
janfb approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@janfb janfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

@michaeldeistler michaeldeistler merged commit 6fed0f4 into main Aug 24, 2022
@michaeldeistler michaeldeistler deleted the snpe-a-fix branch August 24, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janfb janfb janfb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeldeistler @janfb