Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve handling of multi-d x in SNPE, adapt iid test. #780

Merged
merged 1 commit into from
Nov 9, 2022
Merged

improve handling of multi-d x in SNPE, adapt iid test. #780

merged 1 commit into from
Nov 9, 2022

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Nov 9, 2022

closes #767

@janfb janfb added the bug Something isn't working label Nov 9, 2022
@janfb janfb requested a review from michaeldeistler November 9, 2022 07:14
@janfb janfb self-assigned this Nov 9, 2022
@janfb janfb added the documentation Improvements or additions to documentation label Nov 9, 2022
michaeldeistler
michaeldeistler reviewed Nov 9, 2022
View reviewed changes
Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Seeing that the tests pass: I don't understand why it works :D could you clarify (see below)?

sbi/utils/user_input_checks.py Show resolved Hide resolved
tests/embedding_net_test.py Show resolved Hide resolved
@janfb janfb force-pushed the fix-snpe-on-multi-d-x branch from 41786e6 to d864106 Compare November 9, 2022 08:53
@janfb janfb mentioned this pull request Nov 9, 2022
Closed
@janfb janfb merged commit 4b480fb into main Nov 9, 2022
@janfb janfb deleted the fix-snpe-on-multi-d-x branch November 9, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeldeistler michaeldeistler michaeldeistler approved these changes

Assignees

@janfb janfb

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with PermutationInvariantEmbedding: batch dimension for x_o is required
2 participants
@janfb @michaeldeistler