Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the device for is_valid_x #789

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

bkmi
Copy link
Contributor

@bkmi bkmi commented Nov 23, 2022

This PR should address issues in the tests mentioned in #788. The is_valid_x index will be (maybe) copied to the correct device for x and theta before indexing. Thereby a runtime error is avoided.

@codecov-commenter
Copy link

Codecov Report

Merging #789 (5c0bf36) into main (8fe45c9) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #789   +/-   ##
=======================================
  Coverage   74.52%   74.52%           
=======================================
  Files          77       77           
  Lines        6120     6120           
=======================================
  Hits         4561     4561           
  Misses       1559     1559           
Flag Coverage Δ
unittests 74.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sbi/inference/snle/snle_base.py 91.58% <100.00%> (ø)
sbi/inference/snpe/snpe_base.py 89.17% <100.00%> (ø)
sbi/inference/snre/snre_base.py 94.87% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bkmi bkmi force-pushed the fix_embedding_nets_device_test branch from 5c0bf36 to cb1ee7b Compare December 7, 2022 17:39
@bkmi
Copy link
Contributor Author

bkmi commented Dec 7, 2022

this commit fixes the tests that were failing but makes pyright fail

Copy link
Contributor

@janfb janfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks for fixing this!

The pyright issues seem unrelated, I will look into it. Once tests are passing , this is good to go in.

@janfb janfb merged commit 1d98274 into sbi-dev:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants