fix sbc reduce funs, refactor plotting. #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldeistler
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
Oh wow, thanks a lot for fixing this, and sorry for the bug.
I'm wondering how this could slip through this test? Any ideas for better tests here (not necessarily in this PR)?
sbi/analysis/sbc.py
Outdated
| @@ -175,7 +177,9 @@ def sbc_on_batch( | |||
|
|
|||
| # rank for each posterior dimension as in Talts et al. section 4.1. | |||
| for i, reduce_fn in enumerate(reduce_fns): | |||
| ranks[idx, i] = (reduce_fn(ths, xo) < reduce_fn(tho, xo)).sum().item() | |||
| ranks[idx, i] = ( | |||
| (reduce_fn(ths, xo) < reduce_fn(tho.reshape(1, -1), xo)).sum().item() | |||
There was a problem hiding this comment.
I find .reshape(1, -1) hard to parse, maybe use .unsqueeze(0)?
michaeldeistler
approved these changes
Dec 19, 2022
Codecov Report
@@ Coverage Diff @@
## main #793 +/- ##
==========================================
+ Coverage 74.43% 74.62% +0.19%
==========================================
Files 79 79
Lines 6144 6144
==========================================
+ Hits 4573 4585 +12
+ Misses 1571 1559 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when creating the list of
reduce_fns for SBC, we need to index the columns oftheta, not the rows.Addtionally, the local variable
iwill not bind to the correspondinglambdafunctions.I worked around that with an
evalfor now, but there is certainly a more elegant solution out there.closes #794