Initialize a db with only the base module in case install fails #95
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
=======================================
Coverage 64.97% 64.97%
=======================================
Files 19 19
Lines 1245 1245
=======================================
Hits 809 809
Misses 436 436 ☔ View full report in Codecov by Sentry. |
|
@sbidoul what's the status of this? I'm trying to get broken runboat fixed for stock-logistics-workflow v14, ref: OCA/stock-logistics-workflow#1271 (comment) |
|
This is an untested idea so far. But the general idea should work, I think. I don't know when I'll have time to work on this. In the meantime, people should not put modules that conflict at install time in the same repo. Sorry, there is no better solution for now. |
|
@sbidoul I agree with you that they should not be merged, but that has happened here OCA/stock-logistics-workflow#1271 and then we're out of runboat due to a single module :/ |
|
Yes I know. Reverts are a possibility. At some point we could also block merges on a red runboat. |
| unbuffer $(which odoo || which openerp-server) \ | ||
| --data-dir=/mnt/data/odoo-data-dir \ | ||
| --db-template=template1 \ | ||
| -d ${PGDATABASE} \ | ||
| -i ${ADDONS:-base} \ | ||
| --stop-after-init | ||
| --stop-after-init || exit 0 |
There was a problem hiding this comment.
todo: dropdb if install failed ?
| @@ -35,8 +35,6 @@ oca_wait_for_postgres | |||
| # --db_user is necessary for Odoo <= 10 | |||
| unbuffer $(which odoo || which openerp-server) \ | |||
| --data-dir=/mnt/data/odoo-data-dir \ | |||
| --no-database-list \ | |||
There was a problem hiding this comment.
make sure users cannot create databases
sbidoul
changed the title
So users cannot do anything harmful with the database manager, which is now enabled so they can select the base or full database
closes #94