Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Template] PR templateにマージ先がdevであることの確認を追加 #33

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

lsz05
Copy link
Collaborator

@lsz05 lsz05 commented Jun 19, 2024

関連する Issue / PR

N/A

PR をマージした後の挙動の変化

base branchの設定はmainのままでPRを出しがちなので,動作確認にマージ先がdevであることの確認を追加しました。

挙動の変更を達成するために行ったこと

pull_request_template.md変更

動作確認

  • テストが通ることを確認した
  • マージ先がdevブランチであることを確認した

Copy link
Collaborator

@masaya-ohagi masaya-ohagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsz05 lsz05 merged commit 720be03 into dev Jun 19, 2024
3 checks passed
@lsz05 lsz05 mentioned this pull request Jun 20, 2024
1 task
@lsz05 lsz05 deleted the template/merge_confirmation branch August 29, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants